Extract Thumbnails and CropAction concerns #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this module you can add a crop action to any resourceful controller. The model needs to implement the same crop interface as the EssencePicture. A routing concern and a shared example are available as well.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
tvdeyen
force-pushed
the
croppable-resource
branch
2 times, most recently
from
84c982c to
a45539a
Compare
tvdeyen
changed the title
3 tasks
Holds everything you need to make your model being able to display image thumbnails and make use of the image cropper. Your model needs to have `crop_from` and `crop_size` attributes as well as a `Alchemy::Picture` association named `picture` and a `settings` Hash.
tvdeyen
force-pushed
the
croppable-resource
branch
from
a45539a to
f9ddbf6
Compare
tvdeyen
force-pushed
the
croppable-resource
branch
from
f9ddbf6 to
3b20f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
As preparation for #2061 it makes using the image cropper and displaying picture thumbnails easier for models beside the
Alchemy::EssencePictureCropActioncontroller concernWith this module you can add a crop action to any resourceful controller.
The model needs to implement the same crop interface as the EssencePicture.
A routing concern and a shared example are available as well.
PictureThumbnailsconcernHolds everything you need to make your model being able to
display image thumbnails and make use of the image cropper.
Your model needs to have
crop_fromandcrop_sizeattributesas well as a
Alchemy::Pictureassociation namedpictureanda
settingsHash.Checklist