Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate picture thumbnails only for pictures with convertible format #2129

Merged
merged 1 commit into from
Jun 10, 2021
Merged

generate picture thumbnails only for pictures with convertible format #2129

merged 1 commit into from
Jun 10, 2021

Conversation

afdev82
Copy link
Contributor

@afdev82 afdev82 commented Jun 10, 2021

What is this pull request for?

It skips the generation of the thumbnails if the picture doesn't have a convertible format

Closes #2127

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Makes sense

@tvdeyen tvdeyen merged commit 137701d into AlchemyCMS:main Jun 10, 2021
@afdev82
Copy link
Contributor Author

afdev82 commented Jun 10, 2021

And we need to backport this till v5.1

@tvdeyen
Copy link
Member

tvdeyen commented Jun 10, 2021

@afdev82 yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with SVG and thumbnails generation rake tasks
2 participants