[main] Fix execjs to 2.7.0 for developers and CI #2095
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an ecosystem bug in the new release of `execjs`, where the new version (after five years of stability) breaks a few libraries. In our case, it's `handlebars-assets`. I'm opting not to include this fix in the .gemspec file, as I expect this to be rectified pretty soon, and it's not our responsibility to version control transient dependencies.
robinboening
pushed a commit
to robinboening/alchemy_cms
that referenced
this pull request
Jul 2, 2021
There's an ecosystem bug in the new release of `execjs`, where the new version (after five years of stability) breaks a few libraries. In our case, it's `handlebars-assets`. I'm opting not to include this fix in the .gemspec file, as I expect this to be rectified pretty soon, and it's not our responsibility to version control transient dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an ecosystem bug in the new release of
execjs, where the newversion (after five years of stability) breaks a few libraries. In our
case, it's
handlebars-assets.I'm opting not to include this fix in the .gemspec file, as I expect
this to be rectified pretty soon, and it's not our responsibility to
version control transient dependencies.
Checklist