Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import essence video and audio from extension #2089

Merged
merged 7 commits into from
May 6, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 6, 2021

What is this pull request for?

Imports the alchemy-richmedia-essences extension into the core gem.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

tvdeyen added 7 commits May 6, 2021 16:10
This route and action are never used anywhere.
Picture essences never get destroyed in the UI.
If not already existing, because users might have used the
alchemy-richmedia-essence extension
Imported from the lchemy-richmedia-essences extension
So we can play around with it
@tvdeyen tvdeyen added this to the 6.0 milestone May 6, 2021
@tvdeyen tvdeyen requested a review from mamhoff May 6, 2021 15:55
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work!

@tvdeyen tvdeyen merged commit 59101d4 into AlchemyCMS:main May 6, 2021
@tvdeyen tvdeyen deleted the move-essence-video-and-audio branch May 6, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants