Remove deprecated helper method page_active? #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robinboening would you mind the rebase the deprecation out of this PR? The main branch already is v6.0 and the deprecation needs to happen in 5.2-stable. |
this helper was relying on `Page.ancestors_for` which is gone since Alchemy 5.0. We don't need `page_active?` any longer, hence the removal in Alchemy 6.0. Side note: In a separate commit a hotfix and deprecation notice has been added for Alchemy versions 5.0, 5.1 and 5.2.
robinboening
force-pushed
the
remove_page_active_helper
branch
from
7826de3 to
f62a675
Compare
|
My thinking was it doesn't harm to have the deprecation and explanation in the history here as well, but it doesn't matter so I just took it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.