hotfix and deprecate page_active? helper #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robinboening just saw that this PR was targetted to |
The `page_active?` helper used to depend on `Page.ancestors_for` which got removed with AlchemyCMS#1813. This PR hotfixes `page_active?`, but since menus got introduced with AlchemyCMS#1667 the helper is obsolete and is now marked for deletion.
robinboening
force-pushed
the
deprecate_page_active
branch
from
5ebde5e to
2437561
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecogni...
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecognized cop Lint/DuplicateRegexpCharacterClassElement found in .rubocop.yml, unrecognized cop Lint/EmptyBlock found in .rubocop.yml, unrecognized cop Lint/EmptyClass found in .rubocop.yml, unrecognized cop Lint/NoReturnInBeginEndBlocks found in .rubocop.yml, unrecognized cop Lint/ToEnumArguments found in .rubocop.yml, unrecognized cop Lint/UnexpectedBlockArity found in .rubocop.yml, unrecognized cop Lint/UnmodifiedReduceAccumulator found in .rubocop.yml, unrecognized cop Style/ArgumentsForwarding found in .rubocop.yml, unrecognized cop Style/CollectionCompact found in .rubocop.yml, unrecognized cop Style/DocumentDynamicEvalDefinition found in .rubocop.yml, unrecognized cop Style/NegatedIfElseCondition found in .rubocop.yml, unrecognized cop Style/NilLambda found in .rubocop.yml, unrecognized cop Style/RedundantArgument found in .rubocop.yml, unrecognized cop Style/SwapValues found in .rubocop.yml
|
Here you go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
page_active?helper used to depend onPage.ancestors_forwhich got removed with #1813. This PR hotfixespage_active?, but since menus got introduced with #1667 the helper is obsolete and is now marked for deletion.Due to the removal of
Page.ancestors_forin Alchemy 5.0 this commit should be cherry-picked for Alchemy 5.0, 5.1, 5.2