Fast element deletion #2063
Merged
Fast element deletion #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting a collection of elements is rather slow at the moment. As elements as well as contents have a `dependent: :destroy` on them, every dependent record needs to be loaded and destroyed individually. This class uses the knowledge we have of elements, contents and essences in order to be able to destroy a collection of elements in a maximum of less than 20 database calls (if the collection of elements uses a lot of different essences, more calls happen, but there's only a limited amount of essence classes). There's one additional call to the database in here as a safeguard so we do not produce orphaned elements. It's fast, and gives a sense of security.
A page version's elements collection is comprised of all elements linked to a page version, so we can use the fast element deletion class introduced in the previous commit.
robinboening
pushed a commit
to robinboening/alchemy_cms
that referenced
this pull request
Jul 2, 2021
* Add a fast element deletion service class Deleting a collection of elements is rather slow at the moment. As elements as well as contents have a `dependent: :destroy` on them, every dependent record needs to be loaded and destroyed individually. This class uses the knowledge we have of elements, contents and essences in order to be able to destroy a collection of elements in a maximum of less than 20 database calls (if the collection of elements uses a lot of different essences, more calls happen, but there's only a limited amount of essence classes). There's one additional call to the database in here as a safeguard so we do not produce orphaned elements. It's fast, and gives a sense of security. * Use fast element deletion class in page publisher A page version's elements collection is comprised of all elements linked to a page version, so we can use the fast element deletion class introduced in the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This speeds up a part of the page publishing process: That of deleting the existing elements on an already published page. Prior to this PR, element deletion would rely on the element's
before_destroyhooks, needing to make an SQL query for every element in the page tree. This speeds this up considerably by deleting all elements, contents and essences on the page version in 2 + (number of essence types used) queries.Checklist