Create new contents on demand #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of in the view
If new contents have been defined on the elements definition, but they are not existing yet we create them on demand. This happens during rendering (speak loading) elements in the elements window during page edit. Ideally we would only instantiate them, but since the content editors expect a persisted content we cannot do that. This also closes AlchemyCMS#2031
tvdeyen
changed the title
|
This is very helpful. Thanks! Any plans to back-port this to 5.1 & 5.2? If it's not already planned, mind if I cook up a PR for that? |
Not planned yet. But happy to ship this with 5.1 and 5.2 if you open PR(s). |
rickythefox
added a commit
to rickythefox/alchemy_cms
that referenced
this pull request
Apr 7, 2021
tvdeyen
added a commit
that referenced
this pull request
May 5, 2021
…-on-demand Backport #2049 to 5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
If new contents have been defined on the elements definition, but they are not existing yet we create them on demand.
This happens during rendering (speak loading) elements in the elements window during page edit. Ideally we would only instantiate them, but since the content editors expect a persisted content we cannot do that.
Thanks @mamhoff for that smart idea.
This also closes #2031
Checklist