Fix element re-ordering #2028
Merged
Fix element re-ordering #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9b1c68.
Reordering elements does not need to change the elements page id anymore since we removed the trash. This time we do not change the order of the element ids passed via the params. To verify I updated the test so that the elements get created upfront and the order is explicitely assured.
dividedharmony
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Reverts c9b1c68 as this messed the element order by using the arbitary order
that the SQL query we initiated provides.
Fixed by keeping with the order of element ids from the params. This is slightly slower, but keeps the order correct.
Refactored the test in that it now creates the elements upfront in the correct order and then explicitely compares the
position afterwards.
Checklist