Add element definition api (based on PageLayout definitions) #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stockime
force-pushed
the
feature/element_definitions
branch
from
45fff46 to
7d5d316
Compare
tvdeyen
approved these changes
Dec 21, 2020
|
Prettier for Ruby just reached 1.0 and that's how it wanted to format this part ;) |
stockime
force-pushed
the
feature/element_definitions
branch
from
043c7fd to
eae9bcf
Compare
Co-authored-by: Thomas von Deyen <[email protected]>
Guessed that. Personally I am using Rufu, but that also sometimes messes up long strings like that :) |
|
Merged! Thank you for the contribution 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Adds a
ElementDefinitionrepository class (likePageLayout) that allows elements to be registered outside of theelements.ymlfile.This is intended to be used in modules or extensions so that elements offered don't have to be added to the
elements.ymlmanually.Notable changes
To ensure backwards compatability, the
Element::DefinitionsAPI is largely unchanged and just delegates toElementDefinition.ElementDefinitionis an adjusted version of the concern with the general API ofPageLayouton top.Checklist