Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust element editor UI #1979

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 11, 2020

What is this pull request for?

In order to better visually distinguish between the currently edited and other elements on the screen we make the selected element more prominent and dim the hidden ones.

Notable changes

  • Hides hidden elements visually
  • Highlights selected elements
  • Hover effects for better UX

Screenshots

localhost_3000_admin_pages_2_edit(iPad Pro)

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen marked this pull request as ready for review December 11, 2020 14:14
@tvdeyen tvdeyen requested a review from mamhoff December 11, 2020 14:15
@tvdeyen tvdeyen added this to the 5.1 milestone Dec 11, 2020
@tvdeyen tvdeyen changed the title Adjust element styles Adjust element editor UI Dec 11, 2020
@tvdeyen tvdeyen force-pushed the adjust-element-styles branch from 4f18573 to 3b87945 Compare December 12, 2020 21:18
Make it visually more obvious if an element is hidden
In order to better visually distinguish between the currently edited
and other elements on the screen we
make the selected element more prominent
By setting a dedicated text color this also works with the new
selected element style.
@tvdeyen tvdeyen force-pushed the adjust-element-styles branch from 3b87945 to a3251a2 Compare December 15, 2020 14:56
@tvdeyen tvdeyen merged commit a646c8d into AlchemyCMS:main Dec 16, 2020
@tvdeyen tvdeyen deleted the adjust-element-styles branch December 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants