[ruby] Upgrade rubocop to version 1.0.0 #1952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.93.1 → ~> 1.0.0) · Repo · Changelog
Release Notes
1.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 36 commits:
Cut RuboCop 1.0!!!
Move a changelog entry
Fix false positive in `Style/RedundantSelf` cop with nested `self` access (#8585)
Merge pull request #8911 from koic/fix_an_error_when_occurring_cop_error
Fix a false positive for `Layout/SpaceAroundOperators`
Fix an error when ocurring cop error
Merge pull request #8908 from koic/add_extension_versions_when_using_verbose_version
Show extension cop versions when using `--verbose-version` option
Add `on_after_<type>` callbacks
Fix an incorrect auto-correct for `Layout/ClassStructure`
[Docs] Document the documentation license :-)
[Docs] Add some additional documentation in preparation for RuboCop 1.0
Handle redundant parentheses around an interpolated expression for `Style/RedundantParentheses` cop
Merge pull request #8905 from koic/remove_redundant_blank_for_to_json_message
Remove redundant blank for `Lint/ToJSON`'s offense message
[Docs] Update versioning docs for 1.0
Fix `VersionChanged` for `Security/Open`
[Fix #8781] Change how comments are determined for `Style/SafeNavigation` autocorrection.
[Fix #8901] Fix a false positive for `Naming/BinaryOperatorParameterName`
Merge pull request #8894 from koic/fix_a_false_negative_for_security_open
Make `Security/Open` aware of `URI.open`
Default changed to disallow `Layout/TrailingWhitespace` in heredoc.
Don't autocorrect static heredocs with trailing whitespaces
Fix `Layout/TrailingWhitespace` auto-correction in heredoc
[Fix #8044] Change cop department name calculation
[Fix #7944] Add `MaxUnannotatedPlaceholdersAllowed` option to `Style/FormatStringToken` cop.
[Fix #7966] Enable all pending cops for RuboCop 1.0
Update RuboCop/Performance
Update RuboCop/RSpec
Callback building was the single most time consuming method in all RuboCop, at around 8% of overall processing.
Optimize `Cop#restrict_on_send`
Avoid calling `extend` in `initialize`
Remove unused method
Tweak doc
Fix an error for `Style/StringConcatenation` when correcting nested concatenable parts
Switch back the docs version to master
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands