Support nested controllers in modules #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise nested controllers wont be able to rersolve routes
In order to be able to find a controllers alchemy module definition from a nested controller.
tvdeyen
force-pushed
the
support-nested-controllers-in-modules
branch
from
3d1f055 to
21dffc2
Compare
tvdeyen
force-pushed
the
support-nested-controllers-in-modules
branch
from
21dffc2 to
17cfcb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
A controller defined as
Alchemy::Admin::Pages::ListControlleris currently not supported in Alchemy module definitions.This adds support for it.
Notable changes
Changes controller names in the core modules definition from relative to absolute.
Checklist