Fix editing sites #1891
Merged
Fix editing sites #1891
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the site's form partial would only reference the path needed to create a new site, not the one needed to edit an existing one. This commit changes the partial to use `resource_path`, which does the right thing: `/admin/sites/` for creating a new site, `/admin/sites/2/` for editing an existing one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Prior to this commit, the site's form partial would only reference the
path needed to create a new site, not the one needed to edit an
existing one. This commit changes the partial to use
resource_path,which does the right thing:
/admin/sites/for creating a new site,/admin/sites/2/for editing an existing one.Checklist