Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi language menus #1774

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Conversation

rmparr
Copy link
Contributor

@rmparr rmparr commented Apr 3, 2020

What is this pull request for?

Currently, Alchemy Menus will render the first menu item by name, and not the menu item by current language. Now, we can have proper multi-language menus.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

rmparr and others added 3 commits March 30, 2020 13:46
Without this, the menu will find the first root node by name, not the correct root node by language.
Remove site query.

Co-Authored-By: Thomas von Deyen <[email protected]>
@rmparr rmparr force-pushed the multi-language-menus branch from 07fe192 to bdb3bc1 Compare April 3, 2020 09:35
@tvdeyen tvdeyen merged commit 5be4213 into AlchemyCMS:master Apr 3, 2020
@rmparr rmparr deleted the multi-language-menus branch April 3, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants