-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Boarding Flow #1770
Merged
Merged
On Boarding Flow #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will add more functionality to that module
We do not need to test for any language to be present if we load the current language and only redirect to the new language form if that is missing.
Since we do not automatically create new sites implicitely this will help onboarding new users.
Now that we do not implicitely create the default language anymore this will help onboarding new users.
A site needs languages. To better onboard new users we should redirect to the language admin after creating a new site (that does not have any languages yet REMOVE ME)
We want to see links in hints
We would either lose lots of data or orphaned records.
We must not delete a language if there are still pages present. We either would lose a lot of data or orphaned records.
Nice! I also thought that this would be nice when I came to Alchemy first. But somehow I forgot about it. 😉 |
mamhoff
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Ads an on boarding flow that redirects to the sites admin if no site is present yet and redirects to languages admin after creating a site as well as redirecting to the pages admin after creating a language.
Screenshots
Checklist