Remove implicit Site and Language creation #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
remove-implicit-site-creation
branch
3 times, most recently
from
312e032 to
09c82c5
Compare
We do not want to implicitly create a site when none is there. This should be in control of the admin user.
- Fix language factory to not rely on implicit Site creation - Create Site and Language in Node Factory - Page Factory: Ensure no additional language is created
This should inform devs to create a language if necessary.
Implicitly, this was English, but explicitly, our language factory now makes a German language.
If no current language is present, simply do not set `I18n.locale`.
I needed to move authorization up in order to add the right redirect for the case when no language is present.
This was tricky, as the request store is not emptied out between test runs :(.
mamhoff
force-pushed
the
remove-implicit-site-creation
branch
from
09c82c5 to
1cca865
Compare
mamhoff
changed the title
mamhoff
force-pushed
the
remove-implicit-site-creation
branch
from
abf943a to
a7f7a34
Compare
3 tasks
tvdeyen
reviewed
Mar 30, 2020
app/controllers/concerns/alchemy/admin/language_needed_redirects.rb
Outdated
Show resolved
Hide resolved
The redirect feature is already tested at the controller level.
We need a page, otherwise we won't be able to navigate to the menus admin as an Editor.
The redirecting is tested at the controller level.
This should alleviate some of CodeClimate's concerns.
mamhoff
force-pushed
the
remove-implicit-site-creation
branch
from
a7f7a34 to
669943d
Compare
|
Thank you very much 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We do not want to implicitly create a site when none or a language when none is there. This
should be in control of the admin user. Instead, an admin user on a new site gets redirected to sites/languages whenever she tries accessing the pages, layoutpages, or menu admin.
This will make it easier to explicitly do test setup for multi-site and multi-language projects.
Notable changes (remove if none)
We make no use anymore of the default site configuration in
config/alchemy/config.yml.Checklist