Do not use deprecated methods #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method has been deprecated and since we do not want to log deprecation warnings we must not use it.
This method has been deprecated and we do not want to use it internally to avoid loggin deprecation warnings.
tvdeyen
force-pushed
the
do-not-dogfeed-deprecated-methods
branch
from
80656d3 to
ad31bc3
Compare
tvdeyen
added a commit
that referenced
this pull request
Feb 25, 2020
- Do not use deprecated methods [#1737](#1737) ([tvdeyen](https://github.com/tvdeyen)) - Order contents by their position in its element [#1733](#1733) ([tvdeyen](https://github.com/tvdeyen)) - Eager load relations in elements trash [#1732](#1732) ([tvdeyen](https://github.com/tvdeyen)) - Run CI builds with Sprockets 3.7.2 [#1731](#1731) ([tvdeyen](https://github.com/tvdeyen)) - Re-organize development dependencies [#1730](#1730) ([tvdeyen](https://github.com/tvdeyen)) - Update pr template [#1729](#1729) ([tvdeyen](https://github.com/tvdeyen)) - Generate views without _view in the filename [#1728](#1728) ([tvdeyen](https://github.com/tvdeyen)) - Fix CI Builds [#1727](#1727) ([tvdeyen](https://github.com/tvdeyen)) - Fix page tagging condition: should_attach_to_menu? [#1725](#1725) ([mickenorlen](https://github.com/mickenorlen)) - Fix Alchemy.user_class_name constant conflict [#1724](#1724) ([mickenorlen](https://github.com/mickenorlen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We should not use deprecated methods internally.
Otherwise they will log deprecations that users cannot do anything about.