Add Alchemy.user_class_primary_key setting #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we merged 24bef77 we force Rails to connect to the database whenever we eager load the page class. Instead we introduce a config so users with Userclass primary keys different than :id can set it. Refs AlchemyCMS#710 Refs AlchemyCMS#711 Refs AlchemyCMS#1658
|
@afdev82 this will affect you after upgrading to Alchemy 4.4.1. Unfortunately there is no other way to make this working with unnormal primary keys and still support user class eager loading. |
tvdeyen
added a commit
that referenced
this pull request
Jan 8, 2020
- Fix updating page preview after element create/save [#1710](#1710) ([tvdeyen](https://github.com/tvdeyen)) - Element editor layout changes [#1709](#1709) ([tvdeyen](https://github.com/tvdeyen)) - Add Alchemy.user_class_primary_key setting [#1708](#1708) ([tvdeyen](https://github.com/tvdeyen)) - Add Element views upgrade tasks [#1707](#1707) ([tvdeyen](https://github.com/tvdeyen)) - Use postMessage to send messages between preview and element windows [#1704](#1704) ([tvdeyen](https://github.com/tvdeyen))
tvdeyen
added a commit
that referenced
this pull request
Jan 8, 2020
- Fix updating page preview after element create/save [#1710](#1710) ([tvdeyen](https://github.com/tvdeyen)) - Element editor layout changes [#1709](#1709) ([tvdeyen](https://github.com/tvdeyen)) - Add Alchemy.user_class_primary_key setting [#1708](#1708) ([tvdeyen](https://github.com/tvdeyen)) - Add Element views upgrade tasks [#1707](#1707) ([tvdeyen](https://github.com/tvdeyen)) - Use postMessage to send messages between preview and element windows [#1704](#1704) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we merged 24bef77 we force
Rails to connect to the database whenever we eager load the page class.
Instead we introduce a config so users with Userclass primary keys
different than :id can set it.
Refs #710
Refs #711
Refs #1658