Integrate 5.0 work so far #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
tvdeyen
force-pushed
the
five
branch
5 times, most recently
from
18d02d4 to
aafc7c8
Compare
And the default value set correctly on the newly build essence object.
Read the crop and size settings from one canonical source the content settings defined in the elements.yml This reduces complexity and prevents hard to track down errors.
Rely only on the content settings for sizing and cropping settings.
All settings a content might have are set on the contents definition settings key.
This was only done because we supported to have local options in the element editor and essence editor partials. We do not support this anymore and expect to use static content.settings instead.
Passing options as locals to essence editors is not possible anymore. Static values should be set on the content settings on the contents defintion in elements.yml instead. For dynamic values please use a custom essence class.
Speeds up element content editor rendering by making use of Rails collection partial rendering. Also holds all presenter methods from Content model.
Elements do not need an editor partial anymore.
This allows us to move helper classes into this class and render the element editor partial in a more efficient way.
Element view partials should have the element name
Use a ransack search query instead.
The new EssencePage select2 search made this obsolote.
This has been replaced by Menus and the render_menu helper.
This has been replaced by external Menu nodes.
This has been replaced by Menu nodes
We want to remove all deprecations, so we want to see them in the logs.
Make sure that all upgrades have been run under Alchemy 4.4
For existing installations the upgrade task patches the Gutentag migration so they skip the tables if they already exist. While new installations run them.
A new mayor release is a good reason to start fresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Includes all the work already done for 5.0
Notable changes