Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cells in favour of fixed elements #1514

Merged
merged 9 commits into from
Jan 7, 2019
Merged

Remove cells in favour of fixed elements #1514

merged 9 commits into from
Jan 7, 2019
+530 −1,460

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 5, 2018 •
edited
Loading

What is this pull request for?

This removes the Alchemy::Cell as its own entity, but keeps the concept of a fixed element group. It introduces a new fixed option for an element definition. Setting this to true renders the element as a tab in the page edit mode. Combined with nestable_elements this has the same effect as the cell had before, but with less duplication of code and still more flexibility. You can even use contents for a fixed element, show, trash, copy and paste them. All this wasn't possible with cells yet.

TODO

  • Remove cells from template digest tracker
  • Remove render_cell helper
  • Remove from_cell option from render_elements helper
  • Remove cell related tasks from tidy task
  • Fix specs

Sorry, something went wrong.

@tvdeyen tvdeyen self-assigned this Nov 5, 2018
houndci-bot
houndci-bot reviewed Nov 5, 2018
View reviewed changes
@tvdeyen tvdeyen force-pushed the fixed-elements branch 2 times, most recently from f7b7a66 to d0b811f Compare November 11, 2018 22:26
@tvdeyen tvdeyen changed the title WIP: Remove cells in favour of fixed elements Remove cells in favour of fixed elements Nov 11, 2018
@tvdeyen tvdeyen force-pushed the fixed-elements branch 2 times, most recently from de3b05f to d398d3d Compare November 12, 2018 08:06
@tvdeyen tvdeyen removed their assignment Nov 12, 2018
mamhoff
mamhoff reviewed Nov 12, 2018
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a removal!!! I'm commenting and not approving because I haven't had a chance to try this out - also because none of my projects actually use Cells at all.

@tvdeyen tvdeyen mentioned this pull request Dec 10, 2018
Merged
@tvdeyen
Add a "fixed" attribute to elements

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0c60a8a 
In order to simplify the model structure we will remove the the cell as it's own entity, but will keep the fixed layout area feature of cells.
@tvdeyen
Remove cells in favor of nestable elements
66438c9 
Cells are now nestable elements
@tvdeyen
Add cells upgrader tasks
a99bc06 
All cells get converted into nestable elements acting as cell. To help the upgrade please run following tasks:

1. `rake alchemy:upgrade:4.2:convert_cells`
2. `rake alchemy:upgrade:4.2:migrate_cells`
@tvdeyen
Add left column fixed element
93803f7
@tvdeyen
Add removeTab for Alchemy.FixedElements
c001df0
@tvdeyen
Remove tab if fixed element cut into clipboard
c275131
@tvdeyen
Do not allow to drag fixed elements from trash
802f039
@tvdeyen
Remove cells from template tracker
a7a2355 
We do not have cells anymore to track templates for.
@tvdeyen
Remove cell related tasks from tidy:up task
d673b03
@tvdeyen tvdeyen merged commit dae9ec3 into AlchemyCMS:master Jan 7, 2019
@tvdeyen tvdeyen deleted the fixed-elements branch January 7, 2019 10:34
@tvdeyen tvdeyen added this to the 4.2 milestone Jan 26, 2019
tvdeyen added a commit to tvdeyen/alchemy_cms that referenced this pull request Mar 29, 2019
@tvdeyen
v4.2.0.rc1
659fa03 
- Use element name local in generators [AlchemyCMS#1556](AlchemyCMS#1556) ([tvdeyen](https://github.com/tvdeyen))
- Remove invalid bytecode handler [AlchemyCMS#1555](AlchemyCMS#1555) ([tvdeyen](https://github.com/tvdeyen))
- Separate render element calls [AlchemyCMS#1554](AlchemyCMS#1554) ([tvdeyen](https://github.com/tvdeyen))
- Expose the element into partials as local object [AlchemyCMS#1553](AlchemyCMS#1553) ([tvdeyen](https://github.com/tvdeyen))
- Allow admins to switch all languages [AlchemyCMS#1552](AlchemyCMS#1552) ([tvdeyen](https://github.com/tvdeyen))
- Raise targeted Ruby version to 2.3 [AlchemyCMS#1545](AlchemyCMS#1545) ([tvdeyen](https://github.com/tvdeyen))
- Introduces an Elements finder class [AlchemyCMS#1544](AlchemyCMS#1544) ([tvdeyen](https://github.com/tvdeyen))
- Fixate sqlite dep for bug fix [AlchemyCMS#1543](AlchemyCMS#1543) ([tvdeyen](https://github.com/tvdeyen))
- Upgrade shoulda-matchers to version 4.0.0 [AlchemyCMS#1542](AlchemyCMS#1542) ([depfu](https://github.com/apps/depfu))
- Upgrade factory_bot_rails to version 5.0.1 [AlchemyCMS#1540](AlchemyCMS#1540) ([depfu](https://github.com/apps/depfu))
- Use Flatpickr as Datepicker [AlchemyCMS#1533](AlchemyCMS#1533) ([mamhoff](https://github.com/mamhoff))
-  Use system tests over feature specs [AlchemyCMS#1528](AlchemyCMS#1528) ([tvdeyen](https://github.com/tvdeyen))
- Flexible width for admin navigation entry labels [AlchemyCMS#1527](AlchemyCMS#1527) ([tvdeyen](https://github.com/tvdeyen))
- Responsive elements window and sidebar [AlchemyCMS#1519](AlchemyCMS#1519) ([tvdeyen](https://github.com/tvdeyen))
- Change element eye icon on public state [AlchemyCMS#1517](AlchemyCMS#1517) ([oniram88](https://github.com/oniram88))
- Maximize element window if Tinymce is fullscreen [AlchemyCMS#1515](AlchemyCMS#1515) ([tvdeyen](https://github.com/tvdeyen))
- Remove cells in favour of fixed elements [AlchemyCMS#1514](AlchemyCMS#1514) ([tvdeyen](https://github.com/tvdeyen))
- Feature: Autogenerate nestable elements [AlchemyCMS#1513](AlchemyCMS#1513) ([tvdeyen](https://github.com/tvdeyen))
- Allow "data" key for module navigations [AlchemyCMS#1512](AlchemyCMS#1512) ([mamhoff](https://github.com/mamhoff))
- Allow to define layout for page previews [AlchemyCMS#1500](AlchemyCMS#1500) ([westonganger](https://github.com/westonganger))
- Fix capitalization for login/logout/leave [AlchemyCMS#1497](AlchemyCMS#1497) ([westonganger](https://github.com/westonganger))
- Verify controller keys within `register_module` [AlchemyCMS#1495](AlchemyCMS#1495) ([westonganger](https://github.com/westonganger))
- Update bundled Tinymce to 4.8.3 [AlchemyCMS#1491](AlchemyCMS#1491) ([tvdeyen](https://github.com/tvdeyen))
- Use dynamic attributes in factories [AlchemyCMS#1484](AlchemyCMS#1484) ([tvdeyen](https://github.com/tvdeyen))
- Migrating to active_model_serializers ~> 0.10.0 [AlchemyCMS#1478](AlchemyCMS#1478) ([pmashchak](https://github.com/pmashchak))
- Replace picture galleries with nestable elements [AlchemyCMS#1358](AlchemyCMS#1358) ([tvdeyen](https://github.com/tvdeyen))
- Add a compact nested element style [AlchemyCMS#1357](AlchemyCMS#1357) by [tvdeyen](https://github.com/tvdeyen)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff

@houndci-bot houndci-bot

Assignees
No one assigned
Labels
needs changelog
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tvdeyen @mamhoff @houndci-bot