Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple pagination #1471

Merged
merged 11 commits into from
Sep 18, 2018
7 changes: 6 additions & 1 deletion app/controllers/alchemy/admin/base_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,13 @@ def render_errors_or_redirect(object, redirect_url, flash_notice)
end
end

def items_per_page
params[:per_page] || Alchemy::Config.get(:items_per_page)
end

def per_page_value_for_screen_size
return 25 if session[:screen_size].blank?
Alchemy::Deprecation.warn("#per_page_value_for_screen_size is deprecated, please use #items_per_page instead")
return items_per_page if session[:screen_size].blank?
screen_height = session[:screen_size].split('x').last.to_i
(screen_height / 50) - 12
end
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/alchemy/admin/languages_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module Admin
class LanguagesController < ResourcesController
def index
@query = Language.on_current_site.ransack(search_filter_params[:q])
@languages = @query.result.page(params[:page] || 1).per(per_page_value_for_screen_size)
@languages = @query.result.page(params[:page] || 1).per(items_per_page)
end

def new
Expand Down
7 changes: 3 additions & 4 deletions app/controllers/alchemy/admin/pictures_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,12 @@ def destroy
def pictures_per_page_for_size(size)
case size
when 'small'
per_page = in_overlay? ? 25 : (per_page_value_for_screen_size * 2.9).floor
in_overlay? ? 25 : 60
when 'large'
per_page = in_overlay? ? 4 : (per_page_value_for_screen_size / 1.7).floor + 1
in_overlay? ? 4 : 12
else
per_page = in_overlay? ? 9 : (per_page_value_for_screen_size / 1.0).ceil + 4
in_overlay? ? 9 : 20
end
per_page
end

def in_overlay?
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/alchemy/admin/resources_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def index

respond_to do |format|
format.html {
items = items.page(params[:page] || 1).per(per_page_value_for_screen_size)
items = items.page(params[:page] || 1).per(items_per_page)
instance_variable_set("@#{resource_handler.resources_name}", items)
}
format.csv {
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/alchemy/admin/tags_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def index
@tags = @query
.result
.page(params[:page] || 1)
.per(per_page_value_for_screen_size)
.per(items_per_page)
.order("name ASC")
end

Expand Down
5 changes: 5 additions & 0 deletions config/alchemy/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ sitemap:
#
url_nesting: true

# === Default items per page in admin views
#
# In Alchemy's Admin, change how many items you would get shown per page by Kaminari
items_per_page: 10

# === Picture rendering settings
#
# Alchemy uses Dragonfly to render images. Use {size: "XXXxYYY", crop: BOOLEAN [true]} to resize images.
Expand Down