Fix sorting in Resources controller #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Aug 20, 2018
| @@ -46,6 +46,15 @@ | |||
| expect(assigns(:events)).not_to include(lustig) | |||
| end | |||
| end | |||
|
|
|||
| context 'with search parameter given' do | |||
There was a problem hiding this comment.
I'm sure you meant 'with sort parameter given'
Prior to this commit, Ransack sorting would not work with the standard resources controller, as the parameter `q[s]` that is generated by Ransack's `sort_link` helper will be thrown away as insecure.
mamhoff
force-pushed
the
allow-sort-parameter-in-resource-controller
branch
from
7224bb4 to
ea1b4f0
Compare
|
Note to self: Needed because of Ransack 2.0. Works in Ransack 1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Fix sorting in resources controller.
Notable changes (remove if none)
Prior to this commit, Ransack sorting would not work
with the standard resources controller, as the parameter
q[s]that is generated by Ransack'ssort_linkhelperwill be thrown away as insecure.