Fix resources search #1384
Merged
Fix resources search #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all other envs Rails does not raise if unpermitted params are found, it silently drops them. We want the same behavior in test cases. Otherwise we would have to permit or drop every potential parameter.
In Rails 5.1 unpermitted params cause errors while generating urls. Use the sanitized `search_filter_params` in all our resources views instead of the raw `params` fixes this. Fixes AlchemyCMS#1337
Each call to `search_filter_params` permits the params all over again. This is not necessary.
Since we already have `search_filter_params` we do not need the `current_location_params` (which are exactly the same, but unsafe).
tvdeyen
force-pushed
the
fix-resources-search
branch
from
70c28aa to
172f61f
Compare
|
Hey @tvdeyen, could you apply this fix also to the 4.0-stable version? Else you can't properly upgrade to Rails 5.1. in combination with alchemy_cms 4.0.5. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sanitized search filter params in all resource views.
In Rails 5.1 unpermitted params cause errors while generating urls. Use the sanitized
search_filter_paramsin all our resources views instead of the rawparamsFixes this.Fixes #1337