Admin cleanup #1339
Merged
Admin cleanup #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
admin-cleanup
branch
2 times, most recently
from
735e7ef to
99b0032
Compare
mamhoff
approved these changes
Jan 9, 2018
| @@ -29,21 +29,6 @@ table { | |||
| } | |||
| } | |||
|
|
|||
| .floatThead-container { | |||
There was a problem hiding this comment.
Do we use this class anywhere in our HTML?
There was a problem hiding this comment.
No. The plugin that gets removed with this commit adds this DOM node.
Good question. Didn’t checked that. Will do. Bourbon is actually not necessary anymore. |
tvdeyen
force-pushed
the
admin-cleanup
branch
2 times, most recently
from
5f14f57 to
900520f
Compare
Before select2 replaces the selectbox the width is set to 100%, which leads to jumpy UI.
This is a left over from the Sassy buttons removal in a737e5c.
Use plain old border-radius instead.
Flash messages and info/warning messages used to have different colors. They now have a unified look.
These css rules are not used anymore.
The base css file should not hold specific rules
tvdeyen
force-pushed
the
admin-cleanup
branch
from
900520f to
50d5912
Compare
These rules are very old not used in a long time
tvdeyen
force-pushed
the
admin-cleanup
branch
from
50d5912 to
69ce797
Compare
|
@mamhoff removed Bourbon as well. This should be ready to go. Then I can continue working with my other PR |
tvdeyen
force-pushed
the
admin-cleanup
branch
from
69ce797 to
0fa3d57
Compare
This is a terrible hack for sticky table headers. The benefit is debatable and the problems is causes not worth it.
Use `render_message` helper instead of a plain `<p>` tag.
This is not necessary and causes overflowing
We never used much of Bourbon besides the border-radius and clearfix shorthands.
tvdeyen
force-pushed
the
admin-cleanup
branch
from
0fa3d57 to
99e2e57
Compare
|
Added changelog entries for the removals |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of commits that stacked up while working on an Admin UI refresh
%rounded-bordersass extendand more
Best reviewed commit by commit