Add error flash to resource controller

This adds an error flash to the resource controller if some action does
not succeed.

app/controllers/alchemy/admin/resources_controller.rb

@@ -92,8 +92,6 @@ def resource_handler
       # Returns a translated +flash[:notice]+.
       # The key should look like "Modelname successfully created|updated|destroyed."
       def flash_notice_for_resource_action(action = params[:action])
-        return if resource_instance_variable.errors.any?
-
         case action.to_sym
         when :create
           verb = "created"
@@ -102,7 +100,12 @@ def flash_notice_for_resource_action(action = params[:action])
         when :destroy
           verb = "removed"
         end
-        flash[:notice] = Alchemy.t("#{resource_handler.resource_name.classify} successfully #{verb}", default: Alchemy.t("Successfully #{verb}"))
+
+        if action.to_sym == :destroy && resource_instance_variable.errors.any?
+          flash[:error] = resource_instance_variable.errors.full_messages.join(", ")
+        else
+          flash[:notice] = Alchemy.t("#{resource_handler.resource_name.classify} successfully #{verb}", default: Alchemy.t("Successfully #{verb}"))
+        end
       end
 
       def is_alchemy_module?

spec/controllers/alchemy/admin/resources_controller_spec.rb

@@ -137,5 +137,16 @@ def resource_handler
       delete :destroy, params: {id: peter.id}.merge(params)
       expect(response.redirect_url).to eq("http://test.host/admin/events?page=6&q%5Bname_or_hidden_name_or_description_or_location_name_cont%5D=some_query")
     end
+
+    context "If the resource is not destroyable" do
+      let!(:undestroyable) { create(:event, name: "Undestructible") }
+
+      it "adds an error flash" do
+        delete :destroy, params: {id: undestroyable.id}.merge(params)
+
+        expect(response.redirect_url).to eq("http://test.host/admin/events?page=6&q%5Bname_or_hidden_name_or_description_or_location_name_cont%5D=some_query")
+        expect(flash[:error]).to eq("This is the undestructible event!")
+      end
+    end
   end
 end

spec/dummy/app/models/event.rb

@@ -5,6 +5,7 @@ class Event < ActiveRecord::Base
 
   validates_presence_of :name
   belongs_to :location
+  before_destroy :abort_if_name_is_undestructible
 
   scope :starting_today, -> { where(starts_at: Time.current.at_midnight..Date.tomorrow.at_midnight) }
   scope :future, -> { where("starts_at > ?", Date.tomorrow.at_midnight) }
@@ -18,4 +19,13 @@ def self.alchemy_resource_relations
   def self.alchemy_resource_filters
     %w(starting_today future)
   end
+
+  private
+
+  def abort_if_name_is_undestructible
+    if name == "Undestructible"
+      errors.add(:base, "This is the undestructible event!")
+      throw(:abort)
+    end
+  end
 end