-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): migration to ktor v3 #3844
fix(graphql): migration to ktor v3 #3844
Conversation
@AngeloFilaseta, you can target |
K, I'll fix it |
57f9738
to
1f85072
Compare
Hi @AngeloFilaseta! 👋 |
|
@DanySK I discovered the cause of the issue (the timeout). It is not caused by ktor itself. I already changed the code following the migration guide and everything should work within Alchemist. The problem is with another dependency graphql-kotlin, which is still not ready to include ktor v3. So... We wait or what? |
Well, I'd say we wait. Set a timer, and let's check back in a month. |
There are new developments. The |
you forgot the link :) |
Fixed, I should put 1 euro in the virtual wallet for what I thought |
Hi @AngeloFilaseta! 👋 |
Still no solution here, however something is moving, seems like they have a passing CI for KTOR 3.0.3 |
Good! Maybe meanwhile fix the conflicts, so that we don't need to fix a lot of stuff when the fix gets out... |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…or#3933) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ns to v4.9.0 (AlchemistSimulator#4100) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…cate`, improve simulation access from environments, use nullables for `Layer` access (AlchemistSimulator#4105)
…23.0 (AlchemistSimulator#4102) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#4106) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…mulator#4108) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3844 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 90 90
Branches 3 3
======================================
Misses 90 90 ☔ View full report in Codecov by Sentry. |
This branch has conflicts, can you take a look @AngeloFilaseta |
Hi @AngeloFilaseta! 👋 |
|
## [37.1.4](37.1.3...37.1.4) (2025-01-24) ### Dependency updates * **deps:** update dependency gradle to v8.12.1 ([#4129](#4129)) ([fd5ddaa](fd5ddaa)) * **deps:** update ktor monorepo to v3.0.3 ([#4128](#4128)) ([ca52feb](ca52feb)) * **deps:** update plugin multijvmtesting to v3.2.0 ([#4125](#4125)) ([03878df](03878df)) * **deps:** update react to v2025.1.6-19.0.0 ([#4126](#4126)) ([124d522](124d522)) ### Bug Fixes * **graphql:** migrate to ktor v3 ([#3844](#3844)) ([aaa8926](aaa8926)) ### Build and continuous integration * **deps:** update danysk/build-check-deploy-gradle-action action to v3.7.2 ([#4124](#4124)) ([0a33646](0a33646)) ### General maintenance * **build:** actualize the `yarn.lock` file ([75994dd](75994dd)) * **build:** update the javadoc.io cache ([714d366](714d366)) * **build:** update the javadoc.io cache ([9c75ffe](9c75ffe)) * **build:** update the javadoc.io cache ([6b12039](6b12039))
🎉 This PR is included in version 37.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
EmbeddedServer
now encapsulatesApplicationEngine
instead of being a subclass.Sorry for the other PR, it defaulted to master and I didn't notice.