-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cd): automatic AUR release #3081
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3081 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 3 3
Lines 115 106 -9
Branches 5 5
======================================
+ Misses 115 106 -9 ☔ View full report in Codecov by Sentry. |
Hi @Zimbrando! 👋 |
alchemist-full/build.gradle.kts
Outdated
standardOutput = interceptOutput | ||
doFirst { | ||
val version = rootProject.version.toString().substringBefore('-') | ||
commandLine("md5sum", "-b", "${rootProject.layout.buildDirectory.get().asFile.resolve("package").path}/${rootProject.name}-$version-1.x86_64.rpm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need -1
at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jpackage outputs packages following that syntax. I suppose it's the release number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a reason, can you investigate? If there is no reason for it to have -1, I'd like to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a naming convention for .rpm packages, .deb packages follow something similar too
This is tradition and not a restriction, however. Like the version number, the only restriction is that dashes are not allowed. source
I found the jpackage setting, but it seems impossible to disable.
We can modify it to whatever string we would like
Co-authored-by: Danilo Pianini <[email protected]>
Co-authored-by: Danilo Pianini <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Hi @Zimbrando! 👋 |
The contents of this PR are already in mainline through #3107 |
This PR includes:
As soon as #3079 will be merged, this PR needs to update accordingly by integrating artifacts downloads
The package has been already manually uploaded (link)