Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cd): automatic AUR release #3081

Closed
wants to merge 69 commits into from

Conversation

Zimbrando
Copy link
Contributor

@Zimbrando Zimbrando commented Jan 27, 2024

This PR includes:

  • A new gradle task which outputs a valid PKGBUILD script depending on the current rootProject version
  • "test-aur-package" job that installs and asserts that alchemist is correctly installed
  • Steps to update the AUR package when a new release is out

As soon as #3079 will be merged, this PR needs to update accordingly by integrating artifacts downloads

The package has been already manually uploaded (link)

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ee3007) 0.00% compared to head (9b9b8a2) 0.00%.
Report is 20 commits behind head on master.

❗ Current head 9b9b8a2 differs from pull request most recent head 9e12fe1. Consider uploading reports for the commit 9e12fe1 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3081   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         115     106    -9     
  Branches        5       5           
======================================
+ Misses        115     106    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/build-and-deploy.yml Outdated Show resolved Hide resolved
alchemist-full/build.gradle.kts Outdated Show resolved Hide resolved
alchemist-full/build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Jan 29, 2024

Hi @Zimbrando! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

@Zimbrando Zimbrando requested a review from DanySK January 31, 2024 17:01
.github/workflows/build-and-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-deploy.yml Outdated Show resolved Hide resolved
alchemist-full/PKGBUILD.template Outdated Show resolved Hide resolved
alchemist-full/PKGBUILD.template Outdated Show resolved Hide resolved
standardOutput = interceptOutput
doFirst {
val version = rootProject.version.toString().substringBefore('-')
commandLine("md5sum", "-b", "${rootProject.layout.buildDirectory.get().asFile.resolve("package").path}/${rootProject.name}-$version-1.x86_64.rpm")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need -1 at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jpackage outputs packages following that syntax. I suppose it's the release number.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a reason, can you investigate? If there is no reason for it to have -1, I'd like to remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a naming convention for .rpm packages, .deb packages follow something similar too

This is tradition and not a restriction, however. Like the version number, the only restriction is that dashes are not allowed. source

I found the jpackage setting, but it seems impossible to disable.
We can modify it to whatever string we would like

alchemist-full/build.gradle.kts Outdated Show resolved Hide resolved
release.config.js Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

mergify bot commented Feb 5, 2024

Hi @Zimbrando! 👋
This pull request has conflicts 😖
Could you fix it? 🔧
Thank you! 🙏

@DanySK
Copy link
Member

DanySK commented Feb 9, 2024

The contents of this PR are already in mainline through #3107

@DanySK DanySK closed this Feb 9, 2024
@Zimbrando Zimbrando deleted the dev-aur branch February 10, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants