This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
use native websocket ping frames rather than JSON ping #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code was sending a JSON message {"ping":"0123456789"} to test if
the connection was still open — WebSocket has native support for
this.
This is easier for clients as the native ping frames are usually
handled automatically by the WebSocket library.
Note that gevent-websocket doesn't automatically send out ping
frames to keep the connection alive, which servers are supposed
to do. It might be worth switching to another WebSocket library
in the future that is more compliant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was sending a JSON message {"ping":"0123456789"} to test if the connection was still open — WebSocket has native support for this.
This is easier for clients as the native ping frames are usually handled automatically by the WebSocket library.
Note that gevent-websocket doesn't automatically send out ping frames to keep the connection alive, which servers are supposed to do. It might be worth switching to another WebSocket library in the future that is more compliant.