Apply latest token ds-auro-icon-size and update size to fix clipping issue on x icon #345

[rmenner]

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

• New capability
• Revision of an existing capability
• Infrastructure change (automation, etc.)
• Other (please elaborate)

Checklist:

• My update follows the CONTRIBUTING guidelines of this project
• I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix clipping issue on the 'x' icon by updating the icon size and apply the latest token 'ds-auro-icon-size' for consistent icon sizing.

Bug Fixes:

• Fix clipping issue on the 'x' icon by updating the icon size.

Enhancements:

• Apply the latest token 'ds-auro-icon-size' to ensure consistent icon sizing.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR addresses a clipping issue with the 'x' icon by implementing the latest design token 'ds-auro-icon-size' and adjusting icon sizes. The changes primarily involve updating SCSS styles and removing redundant icon customizations in the JavaScript component.

Class diagram for AuroInput component changes

classDiagram
    class AuroInput {
        - customSize
        + category: String
        + name: String
        + customColor: Boolean
        + hidden: Boolean
    }
    note for AuroInput "Removed customSize attribute from icon elements"

Loading

File-Level Changes

Change	Details	Files
Implement new design token for icon sizing and adjust dimensions	Add --ds-auro-icon-size token with value of ds-size-300 Remove redundant width property since it's handled by the new token Increase alert notification size from ds-size-200 to ds-size-300 Add --ds-auro-icon-size token with value of ds-size-200 for smaller icons	src/styles/notificationIcons.scss
Remove unnecessary icon customization attributes	Remove customSize attribute from error icon Remove customSize attribute from password visibility icons Remove customSize attribute from clear button icon	src/auro-input.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

• The removal of buttonVersion.js and iconVersion.js files needs explanation. If version tracking is being moved elsewhere, please document the new approach. If this was unintentional, please restore these files.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jordanjones243]

Code looks good, but there is an issue with the alignment with the type icon and text. Please look at the attached pictures below to recognize the difference. This may or may not have been caused by the changes in this PR, but needs to be fixed regardless before release.

Misalignment:

Correct alignment:

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ chrisfalaska
✅ rmenner
✅ jason-capsule42
✅ jordanjones243
❌ semantic-release-bot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jordanjones243]

Three issues:

• Conflicting package-lock.json file

• Error icon is misaligned vertically on non-bordered inputs
  

• Error icon does not have enough padding from border on bordered inputs
  

Refer to this figma for correct layout:
https://www.figma.com/design/VpUz89Ov6ImBpY5YvzYbZW/Auro-toolkit?node-id=0-1918&node-type=canvas&m=dev

[rmenner]

@sourcery-ai review

[sourcery-ai]

Hey @rmenner - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jordanjones243]

Issue with PR when trying to merge. Either needs to be rebased or new PR needs to be created.

[rmenner]

Closed and reopened as new PR #358 Had issues merging this PR