Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement formvalidation repo #130

Merged
merged 15 commits into from
May 10, 2024
Merged

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Apr 2, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #127, #129

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Implement auro-formvalidation repo
  • Update JS docs
  • Update dependencies
  • Update styles to fix focus UI borders

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Apr 2, 2024
@jordanjones243
Copy link
Contributor Author

This PR will stay in draft mode until all form elements have auro-formvalidation implementation

Copy link

github-actions bot commented Apr 2, 2024

Surge demo deployment failed! 😭

@jordanjones243 jordanjones243 linked an issue Apr 2, 2024 that may be closed by this pull request
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#129 branch from 867e370 to bf1b1bb Compare April 3, 2024 17:09
src/auro-checkbox-group.js Outdated Show resolved Hide resolved
src/auro-checkbox-group.js Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 marked this pull request as ready for review April 5, 2024 20:54
@jordanjones243 jordanjones243 requested a review from a team as a code owner April 5, 2024 20:54
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#129 branch 2 times, most recently from c127842 to 0b5b366 Compare April 29, 2024 20:47
demo/api.md Outdated Show resolved Hide resolved
demo/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
test/auro-checkbox.test.js Show resolved Hide resolved
Copy link
Member

@jason-capsule42 jason-capsule42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add in the new library utility that adds the element name as an attribute on both checkbox and group if it's been custom registered.

@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#129 branch from 2cefc95 to 89b7096 Compare April 30, 2024 14:08
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#129 branch from 82d126c to 30f4376 Compare April 30, 2024 14:16
@jordanjones243 jordanjones243 requested a review from leeejune April 30, 2024 14:17
@jordanjones243 jordanjones243 linked an issue Apr 30, 2024 that may be closed by this pull request
docs/partials/api.md Show resolved Hide resolved
apiExamples/error.html Show resolved Hide resolved
demo/api.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/auro-checkbox-group.js Outdated Show resolved Hide resolved
src/auro-checkbox-group.js Show resolved Hide resolved
src/auro-checkbox-group.js Show resolved Hide resolved
test/auro-checkbox.test.js Outdated Show resolved Hide resolved
test/auro-checkbox.test.js Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#129 branch 2 times, most recently from 344be6a to 057e2b1 Compare May 1, 2024 21:29
@jordanjones243 jordanjones243 marked this pull request as draft May 2, 2024 19:03
@jordanjones243 jordanjones243 marked this pull request as ready for review May 6, 2024 16:18
jordanjones243 and others added 5 commits May 10, 2024 11:00
BREAKING CHANGE: The individual component validation, as well as support for individual checkboxes using the required attribute has been removed.
This commit fixes an issue with web-component-analyzer not properly
creating the documentation due to the incorrect placement of the JSDoc
descriptions.

Changes to be committed:
modified:   demo/api.md
modified:   docs/api.md
modified:   src/auro-checkbox-group.js
This commit updates the package scripts and test-publish workflow to
ensure testing of code in the remote per this Discussion.

https://github.com/orgs/AlaskaAirlines/discussions/523

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package.json
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#129 branch from 0f93a97 to 6ec6fd4 Compare May 10, 2024 18:00
@jason-capsule42 jason-capsule42 merged commit 150cf3c into master May 10, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/formvalidation/#129 branch May 10, 2024 18:15
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement auro-formvalidation focus-visible code is missing
3 participants