-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement formvalidation repo #130
Conversation
This PR will stay in draft mode until all form elements have |
Surge demo deployment failed! 😭 |
867e370
to
bf1b1bb
Compare
c127842
to
0b5b366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to add in the new library utility that adds the element name as an attribute on both checkbox and group if it's been custom registered.
2cefc95
to
89b7096
Compare
82d126c
to
30f4376
Compare
344be6a
to
057e2b1
Compare
BREAKING CHANGE: The individual component validation, as well as support for individual checkboxes using the required attribute has been removed.
This commit fixes an issue with web-component-analyzer not properly creating the documentation due to the incorrect placement of the JSDoc descriptions. Changes to be committed: modified: demo/api.md modified: docs/api.md modified: src/auro-checkbox-group.js
This commit updates the package scripts and test-publish workflow to ensure testing of code in the remote per this Discussion. https://github.com/orgs/AlaskaAirlines/discussions/523 Changes to be committed: modified: .github/workflows/testPublish.yml modified: package.json
Changes to be committed: modified: package-lock.json modified: package.json
0f93a97
to
6ec6fd4
Compare
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #127, #129
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
auro-formvalidation
repoType of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team