-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update color tokens #61
Conversation
dee5df9
to
048bbac
Compare
048bbac
to
cc2b3bd
Compare
cc2b3bd
to
a24d89c
Compare
.disclaimer { | ||
color: var(--ds-auro-banner-disclaimer-text-color); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the logic on this to use the WCSS fineprint feature we added in the past
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that, we need to make sure that is "themeable" as well.
I am seeing this in a few repos where there are tier 3 tokens being defined, when using this syntax pattern, Sass Interpolation is needed to process the Sass var into a value.
|
a24d89c
to
23368e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made several updates based on the previous review comments in an attempt to get this done.
However, there is one issue that still needs attention. All the banner images are misaligned on the bottom of the banner. This needs to be fixed before this can release to beta.
The issue that is seen has been verified to appear in the |
🎉 This PR is included in version 2.1.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #57
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
Verification
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team