Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens #61

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Update color tokens #61

merged 3 commits into from
Jul 9, 2024

Conversation

jordanjones243
Copy link
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #57

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update all dependencies, most importantly the design tokens
  • Refactor color tokens by isolating the color tokens and creating tier 3 tokens for repeatable rules

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification

  • Tier 3 tokens are appropriately named
  • Tier 3 tokens are pointing to correct tier 2 tokens

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Jun 6, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner June 6, 2024 19:24
@jordanjones243 jordanjones243 linked an issue Jun 6, 2024 that may be closed by this pull request
2 tasks
@jordanjones243 jordanjones243 force-pushed the jjones/updateColorTokens/#57 branch from dee5df9 to 048bbac Compare June 25, 2024 22:34
@jordanjones243 jordanjones243 changed the base branch from main to beta June 25, 2024 22:35
@jordanjones243 jordanjones243 force-pushed the jjones/updateColorTokens/#57 branch from 048bbac to cc2b3bd Compare June 25, 2024 22:36
@jordanjones243 jordanjones243 force-pushed the jjones/updateColorTokens/#57 branch from cc2b3bd to a24d89c Compare June 25, 2024 22:36
Comment on lines +24 to +26
.disclaimer {
color: var(--ds-auro-banner-disclaimer-text-color);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the logic on this to use the WCSS fineprint feature we added in the past

AlaskaAirlines/WebCoreStyleSheets#101

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that, we need to make sure that is "themeable" as well.

@blackfalcon
Copy link
Member

blackfalcon commented Jul 8, 2024

I am seeing this in a few repos where there are tier 3 tokens being defined, when using this syntax pattern, Sass Interpolation is needed to process the Sass var into a value.

--ds-auro-banner-wrapper-border-color: var(--ds-color-border-primary-default, #{$ds-color-border-primary-default});

Copy link
Member

@jason-capsule42 jason-capsule42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made several updates based on the previous review comments in an attempt to get this done.

However, there is one issue that still needs attention. All the banner images are misaligned on the bottom of the banner. This needs to be fixed before this can release to beta.

@jordanjones243
Copy link
Contributor Author

I made several updates based on the previous review comments in an attempt to get this done.

However, there is one issue that still needs attention. All the banner images are misaligned on the bottom of the banner. This needs to be fixed before this can release to beta.

The issue that is seen has been verified to appear in the main branch as well, meaning the work from this repo can proceed.

@jason-capsule42 jason-capsule42 dismissed blackfalcon’s stale review July 9, 2024 21:21

Comments addressed

@jason-capsule42 jason-capsule42 merged commit 8f451b7 into beta Jul 9, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/updateColorTokens/#57 branch July 9, 2024 21:39
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
3 participants