Skip to content

Commit

Permalink
[iOS] Clean up BVC imports and dependencies.
Browse files Browse the repository at this point in the history
Removes ~24 unneeded includes from the BVC, and, where possible, the
corresponding deps in BUILD.gn


Change-Id: Ic29411dd8dedb8fc709145ac214434f481e7b557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229545
Commit-Queue: Mark Cogan <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#937980}
  • Loading branch information
marcq authored and Chromium LUCI CQ committed Nov 3, 2021
1 parent 27a6bd0 commit a969490
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 35 deletions.
10 changes: 0 additions & 10 deletions ios/chrome/browser/ui/browser_view/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@ source_set("browser_view") {
"//components/omnibox/browser",
"//components/profile_metrics",
"//components/reading_list/core",
"//components/search_engines",
"//components/sessions",
"//components/signin/core/browser",
"//components/signin/ios/browser",
"//components/signin/ios/browser:active_state_manager",
"//components/signin/public/identity_manager",
"//components/strings",
"//components/translate/core/browser",
"//components/ukm/ios:ukm_url_recorder",
Expand All @@ -51,7 +49,6 @@ source_set("browser_view") {
"//ios/chrome/browser/favicon",
"//ios/chrome/browser/feature_engagement",
"//ios/chrome/browser/find_in_page",
"//ios/chrome/browser/first_run",
"//ios/chrome/browser/geolocation",
"//ios/chrome/browser/infobars",
"//ios/chrome/browser/language",
Expand All @@ -66,11 +63,9 @@ source_set("browser_view") {
"//ios/chrome/browser/overlays/public/web_content_area",
"//ios/chrome/browser/overscroll_actions",
"//ios/chrome/browser/passwords",
"//ios/chrome/browser/policy:policy_util",
"//ios/chrome/browser/prefs",
"//ios/chrome/browser/prerender",
"//ios/chrome/browser/reading_list",
"//ios/chrome/browser/search_engines",
"//ios/chrome/browser/send_tab_to_self",
"//ios/chrome/browser/sessions",
"//ios/chrome/browser/sessions:restoration_agent",
Expand Down Expand Up @@ -116,7 +111,6 @@ source_set("browser_view") {
"//ios/chrome/browser/ui/fullscreen:ui",
"//ios/chrome/browser/ui/gestures",
"//ios/chrome/browser/ui/history",
"//ios/chrome/browser/ui/image_util:web",
"//ios/chrome/browser/ui/incognito_reauth:incognito_reauth_commands",
"//ios/chrome/browser/ui/incognito_reauth:incognito_reauth_scene_agent",
"//ios/chrome/browser/ui/incognito_reauth:incognito_reauth_ui",
Expand All @@ -127,7 +121,6 @@ source_set("browser_view") {
"//ios/chrome/browser/ui/main:scene_state_header",
"//ios/chrome/browser/ui/main_content:main_content_ui",
"//ios/chrome/browser/ui/main_content:main_content_ui_broadcasting_util",
"//ios/chrome/browser/ui/menu",
"//ios/chrome/browser/ui/ntp",
"//ios/chrome/browser/ui/ntp:coordinator",
"//ios/chrome/browser/ui/ntp:logo",
Expand Down Expand Up @@ -184,13 +177,11 @@ source_set("browser_view") {
"//ios/chrome/browser/web:page_placeholder",
"//ios/chrome/browser/web:tab_helper_delegates",
"//ios/chrome/browser/web/font_size",
"//ios/chrome/browser/web/image_fetch",
"//ios/chrome/browser/web/print",
"//ios/chrome/browser/web_state_list",
"//ios/chrome/browser/web_state_list:agents",
"//ios/chrome/browser/web_state_list/web_usage_enabler",
"//ios/chrome/browser/webui",
"//ios/chrome/browser/window_activities",
"//ios/chrome/common",
"//ios/chrome/common/ui/colors",
"//ios/chrome/common/ui/promo_style",
Expand All @@ -205,7 +196,6 @@ source_set("browser_view") {
"//ios/third_party/material_components_ios",
"//ios/third_party/webkit",
"//ios/web",
"//ios/web/common",
"//ios/web/public",
"//ios/web/public/deprecated",
"//ios/web/public/deprecated:deprecated_web_util",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#import "base/ios/block_types.h"
#import "ios/chrome/browser/ui/find_bar/find_bar_coordinator.h"
#import "ios/chrome/browser/ui/gestures/view_revealing_vertical_pan_handler.h"
#import "ios/chrome/browser/ui/incognito_reauth/incognito_reauth_consumer.h"
#import "ios/chrome/browser/ui/ntp/logo_animation_controller.h"
#import "ios/chrome/browser/ui/page_info/requirements/page_info_presentation.h"
Expand Down
25 changes: 1 addition & 24 deletions ios/chrome/browser/ui/browser_view/browser_view_controller.mm
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#import <MaterialComponents/MaterialSnackbar.h>

#include "base/base64.h"
#import "base/ios/ios_util.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/foundation_util.h"
#include "base/metrics/histogram_macros.h"
Expand All @@ -21,13 +20,10 @@
#include "components/feature_engagement/public/tracker.h"
#include "components/omnibox/browser/location_bar_model_impl.h"
#include "components/reading_list/core/reading_list_model.h"
#include "components/search_engines/template_url_service.h"
#include "components/sessions/core/tab_restore_service_helper.h"
#include "components/signin/core/browser/account_reconcilor.h"
#import "components/signin/ios/browser/account_consistency_service.h"
#include "components/signin/ios/browser/active_state_manager.h"
#import "components/signin/ios/browser/manage_accounts_delegate.h"
#include "components/signin/public/base/consent_level.h"
#include "components/strings/grit/components_strings.h"
#include "components/translate/core/browser/translate_manager.h"
#include "components/ukm/ios/ukm_url_recorder.h"
Expand All @@ -39,7 +35,6 @@
#include "ios/chrome/browser/feature_engagement/tracker_factory.h"
#include "ios/chrome/browser/feature_engagement/tracker_util.h"
#import "ios/chrome/browser/find_in_page/find_tab_helper.h"
#include "ios/chrome/browser/first_run/first_run.h"
#include "ios/chrome/browser/infobars/infobar_manager_impl.h"
#import "ios/chrome/browser/language/url_language_histogram_factory.h"
#import "ios/chrome/browser/main/browser.h"
Expand All @@ -50,15 +45,11 @@
#import "ios/chrome/browser/overscroll_actions/overscroll_actions_tab_helper.h"
#import "ios/chrome/browser/passwords/password_controller.h"
#include "ios/chrome/browser/passwords/password_tab_helper.h"
#import "ios/chrome/browser/policy/policy_util.h"
#import "ios/chrome/browser/prerender/preload_controller_delegate.h"
#import "ios/chrome/browser/prerender/prerender_service.h"
#import "ios/chrome/browser/prerender/prerender_service_factory.h"
#import "ios/chrome/browser/reading_list/offline_page_tab_helper.h"
#include "ios/chrome/browser/reading_list/offline_url_utils.h"
#include "ios/chrome/browser/reading_list/reading_list_model_factory.h"
#include "ios/chrome/browser/search_engines/search_engines_util.h"
#include "ios/chrome/browser/search_engines/template_url_service_factory.h"
#include "ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h"
#import "ios/chrome/browser/sessions/session_restoration_browser_agent.h"
#import "ios/chrome/browser/signin/account_consistency_service_factory.h"
Expand All @@ -70,7 +61,6 @@
#import "ios/chrome/browser/ssl/captive_portal_detector_tab_helper_delegate.h"
#import "ios/chrome/browser/tabs/tab_title_util.h"
#import "ios/chrome/browser/translate/chrome_ios_translate_client.h"
#import "ios/chrome/browser/ui/activity_services/requirements/activity_service_positioner.h"
#import "ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h"
#import "ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.h"
#import "ios/chrome/browser/ui/authentication/signin_presenter.h"
Expand Down Expand Up @@ -101,10 +91,7 @@
#import "ios/chrome/browser/ui/fullscreen/fullscreen_ui_element.h"
#import "ios/chrome/browser/ui/fullscreen/fullscreen_ui_updater.h"
#include "ios/chrome/browser/ui/fullscreen/scoped_fullscreen_disabler.h"
#import "ios/chrome/browser/ui/gestures/view_revealing_animatee.h"
#import "ios/chrome/browser/ui/gestures/view_revealing_vertical_pan_handler.h"
#import "ios/chrome/browser/ui/image_util/image_copier.h"
#import "ios/chrome/browser/ui/image_util/image_saver.h"
#import "ios/chrome/browser/ui/incognito_reauth/incognito_reauth_commands.h"
#import "ios/chrome/browser/ui/incognito_reauth/incognito_reauth_scene_agent.h"
#import "ios/chrome/browser/ui/incognito_reauth/incognito_reauth_view.h"
Expand All @@ -116,8 +103,6 @@
#import "ios/chrome/browser/ui/main_content/main_content_ui_broadcasting_util.h"
#import "ios/chrome/browser/ui/main_content/main_content_ui_state.h"
#import "ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.h"
#import "ios/chrome/browser/ui/menu/browser_action_factory.h"
#import "ios/chrome/browser/ui/menu/menu_histograms.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_coordinator.h"
#import "ios/chrome/browser/ui/ntp/ntp_util.h"
#import "ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.h"
Expand Down Expand Up @@ -152,7 +137,6 @@
#import "ios/chrome/browser/ui/util/named_guide.h"
#import "ios/chrome/browser/ui/util/named_guide_util.h"
#import "ios/chrome/browser/ui/util/page_animation_util.h"
#import "ios/chrome/browser/ui/util/pasteboard_util.h"
#import "ios/chrome/browser/ui/util/uikit_ui_util.h"
#import "ios/chrome/browser/ui/util/url_with_title.h"
#import "ios/chrome/browser/ui/voice/text_to_speech_playback_controller.h"
Expand All @@ -164,14 +148,11 @@
#import "ios/chrome/browser/url_loading/url_loading_params.h"
#import "ios/chrome/browser/url_loading/url_loading_util.h"
#import "ios/chrome/browser/voice/voice_search_navigations_tab_helper.h"
#import "ios/chrome/browser/web/image_fetch/image_fetch_tab_helper.h"
#import "ios/chrome/browser/web/page_placeholder_tab_helper.h"
#import "ios/chrome/browser/web/repost_form_tab_helper.h"
#import "ios/chrome/browser/web/sad_tab_tab_helper.h"
#import "ios/chrome/browser/web/tab_id_tab_helper.h"
#import "ios/chrome/browser/web/web_navigation_browser_agent.h"
#import "ios/chrome/browser/web/web_navigation_util.h"
#import "ios/chrome/browser/web/web_state_container_view_provider.h"
#import "ios/chrome/browser/web_state_list/all_web_state_observation_forwarder.h"
#import "ios/chrome/browser/web_state_list/tab_insertion_browser_agent.h"
#import "ios/chrome/browser/web_state_list/web_state_list.h"
Expand All @@ -180,7 +161,6 @@
#import "ios/chrome/browser/webui/net_export_tab_helper.h"
#import "ios/chrome/browser/webui/net_export_tab_helper_delegate.h"
#import "ios/chrome/browser/webui/show_mail_composer_context.h"
#import "ios/chrome/browser/window_activities/window_activity_helpers.h"
#import "ios/chrome/common/ui/colors/semantic_color_names.h"
#import "ios/chrome/common/ui/promo_style/promo_style_view_controller.h"
#import "ios/chrome/common/ui/util/constraints_ui_util.h"
Expand All @@ -189,9 +169,6 @@
#include "ios/public/provider/chrome/browser/lens/lens_configuration.h"
#include "ios/public/provider/chrome/browser/voice_search/voice_search_api.h"
#include "ios/public/provider/chrome/browser/voice_search/voice_search_controller.h"
#import "ios/web/common/crw_input_view_provider.h"
#include "ios/web/common/features.h"
#include "ios/web/common/url_scheme_util.h"
#import "ios/web/public/deprecated/crw_js_injection_receiver.h"
#import "ios/web/public/deprecated/crw_web_controller_util.h"
#include "ios/web/public/navigation/navigation_item.h"
Expand Down Expand Up @@ -714,7 +691,7 @@ - (instancetype)initWithBrowser:(Browser*)browser

_inNewTabAnimation = NO;

_fullscreenController = FullscreenController::FromBrowser(browser);
_fullscreenController = FullscreenController::FromBrowser(browser);

_footerFullscreenProgress = 1.0;

Expand Down

0 comments on commit a969490

Please sign in to comment.