Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom image transition #9

Closed
wants to merge 1 commit into from
Closed

Custom image transition #9

wants to merge 1 commit into from

Conversation

kcharwood
Copy link
Contributor

In this PR I did the following:

  • Added a Custom Image Transition case that allows a developer to create their own animation transition
  • This case also allows developers to receive a callback when the image transition is completed
  • This breaks existing behavior where there were cases where the image was not automatically set. Now forward, the image will automatically be set by the library in all cases.
  • Updated documentation to reflect new behavior
  • Updated tests to meet new assumptions
  • Added new tests to test new functionality.

@kcharwood kcharwood force-pushed the custom_image_transition branch from 9c5105d to 9ca80c1 Compare September 15, 2015 21:42
@kcharwood
- Added a Custom Image Transition case
5501afa 
- Modified the completion closure behavior to automatically set the image in all cases now
@kcharwood kcharwood force-pushed the custom_image_transition branch from 9ca80c1 to 5501afa Compare September 15, 2015 21:44
kcharwood added a commit that referenced this pull request Sep 16, 2015
@kcharwood @cnoon
[PR #9] Added Custom image transition and modified completion behavior.
206c08c 
- Added a Custom Image Transition case
- Modified the completion closure behavior to automatically set the image in all cases now
kcharwood added a commit that referenced this pull request Sep 16, 2015
@kcharwood @cnoon
[PR #9] Added Custom image transition and modified completion behavior.
4f950f5 
- Added a Custom Image Transition case
- Modified the completion closure behavior to automatically set the image in all cases now
kcharwood added a commit that referenced this pull request Sep 16, 2015
@kcharwood @cnoon
[PR #9] Added Custom image transition and modified completion behavior.
42c590e
@cnoon
Copy link
Member

cnoon commented Sep 16, 2015

Nice work here @kcharwood! I pushed a slightly modified version of your changes in 42c590e. The changes I added include:

  • Additional setImageWithURL method that takes a completion closure

    Now you don't have to create an NSURLRequest just to use the completion closure 🙌🏼 🙌🏼 🙌🏼

  • The completion closure is now called prior to all image transitions (even .None case)

    This greatly simplifies the logic and makes all behavior consistent

  • Updated the docs with the behavioral changes

  • Small formatting tweaks

Looks really solid...thanks again for putting this together! 🍻

@cnoon cnoon closed this Sep 16, 2015
@cnoon cnoon added this to the 1.1.0 milestone Sep 16, 2015
@cnoon cnoon self-assigned this Sep 16, 2015
@cnoon cnoon deleted the custom_image_transition branch September 16, 2015 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cnoon cnoon

Labels
enhancement uiimageview
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kcharwood @cnoon