Extent for output file in af_imageWithAppliedCoreImageFilter:filterName:filterParameters: #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t was an image with different extent
|
Thanks for putting this together @fsaint...much appreciated! This was definitely a bug that unfortunately we didn't notice. Looking at the image you modified makes it pretty obvious. Thank you for taking the time to put this together! 🍻 |
cnoon
added a commit
that referenced
this pull request
Feb 4, 2016
Extent for output file in af_imageWithAppliedCoreImageFilter:filterName:filterParameters:
|
Just FYI...I also pushed b860826 to fix up the test suite on various OS's. The blur filter produces quite different results on |
|
Could this be added as a setting to the method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extent used to crop the output image was the original's image extent. This works in filters that don't change or change the extent minimally. For filters that change the extent significantly (for example "CIPerspectiveCorrection") the bug is quite evident.
I also updated the image of the test cases. In the original test image, the worn cropping caused the image to lave some sharp edges caused by a too small crop.