Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extension to UIButton to support remote images #63

Closed
wants to merge 2 commits into from

Conversation

jorjuela33
Copy link
Contributor

I am using this library in some personals projects and I noticed about there is not support to set a remote image as a background or image, I ended with this solution for iOS that can help with the #13 . I hope it fits the requirements and guidelines of AlamofireImage.

Regards.

@cnoon
Copy link
Member

cnoon commented Dec 20, 2015

Okay this looks like an awesome start @jorjuela33. I'll spend some time here in the next few days digging through this in detail, but it looks really solid at first glance. The one thing that jumps out at me right now is that the test suite is failing on watchOS. I would guess that there needs to be some checks here for handling the different OSs properly. My guess here is that you probably only want these files included in the iOS framework and test target. Not sure about tvOS...so we should look into that as well.

@cnoon cnoon added the uibutton label Dec 20, 2015
@cnoon cnoon self-assigned this Dec 20, 2015
@cnoon cnoon added this to the 2.3.0 milestone Dec 20, 2015
@cnoon cnoon mentioned this pull request Dec 20, 2015
@jorjuela33
Copy link
Contributor Author

@cnoon I didn't check for the watchOS, I just tested for iOS. But If I can help with something else please let me know. I will be glad.

Regards.

@cnoon
Copy link
Member

cnoon commented Jan 3, 2016

Hi @jorjuela33...thank you so much for all your hard work here. I squashed your two commits into a single one in 5722c33. Then I refactored a few things in 010750d (diff looks much worse than it really was). Then I added accept header tests in 3000c6f and cancellation tests in 09a4f70. That last commit was pretty important since the previous implementation suffered from the same cancellation bug as the UIImageView extension did. Thankfully it's all fixed up and looking really solid.

Thanks again for putting this together. I'll hopefully get everything released tomorrow. 🍻

@cnoon cnoon closed this Jan 3, 2016
@cnoon
Copy link
Member

cnoon commented Jan 3, 2016

I would release tonight, but I need to put together a new section in the README for the UIButton extension.

@jorjuela33
Copy link
Contributor Author

@cnoon Nice! thanks so much to consider this code and I hope to continue contributing

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants