Add a method to enqueue multiple image downloads. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| var receipts: [RequestReceipt] = [] | ||
|
|
||
| for request in URLRequests { |
There was a problem hiding this comment.
This could be done far shorter with flatMap
return URLRequests.flatMap {
downloadImage(URLRequest: $0, filter: filter, completion: completion)
}
|
@kylef: Good call! |
|
Thanks for this @SlaunchaMan! I've merged a slightly modified version of your PR in 50e2725 still giving you attribution. We'll probably release this as part of the many features going out in 2.2.0. Thanks again! 🍻 |
|
This is nice. I'll pull this into a future version of AFNetworking. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often like to pre-populate image caches so that images are already downloaded when the user gets to a part of our apps. This PR adds a method to do that to the
ImageDownloaderclass.