Feature - New ImageDownloader Initializer Accepting Manager #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kcharwood and @jshier |
| @@ -86,17 +86,23 @@ public class ImageDownloader { | |||
| /// The credential used for authenticating each download request. | |||
| public private(set) var credential: NSURLCredential? | |||
|
|
|||
| var queuedRequests: [Request] | |||
| var activeRequestCount: Int | |||
| let sessionManager: Alamofire.Manager | |||
There was a problem hiding this comment.
Don't generally put docstrings on anything other than public properties unless they aren't self documenting.
cnoon
added a commit
that referenced
this pull request
Oct 14, 2015
…lization Feature - New ImageDownloader Initializer Accepting Manager
|
Is this available through cocoa pods yet? |
|
It is not @phongleq. Working on getting it out here soon. Should drop tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the
ImageDownloaderto accept a custom AlamofireManagerinstance directly rather than having to initialize one from anNSURLSessionConfiguration. When using this in tandem with the new initializers in Alamofire 3.0, the user now has FULL control over all theNSURLSessioninitialization.