Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] S3 Issue #163

Closed
wants to merge 1 commit into from
Closed

[iOS] S3 Issue #163

wants to merge 1 commit into from

Conversation

odemolliens
Copy link

@odemolliens odemolliens commented Sep 5, 2016

With current version, when we try to get an S3 image with JPG, AlamofireImage throw an error (403 - contentTypeValidationError)

Of course we can add:
Request.addAcceptableImageContentTypes(["image/jpg"])

But it seem's to be better to add it in the library (jpg is a standard format)

@cnoon
Copy link
Member

cnoon commented Sep 7, 2016

Thanks for the PR @odemolliens. Unfortunately we won't be merging this due to image/jpg not being a standard format. You can easily add it to the list of acceptable content types though using the addAcceptableImageContentTypes API.

Please see #29 and #33 for more info.

Cheers. 🍻

@cnoon cnoon closed this Sep 7, 2016
@cnoon cnoon self-assigned this Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants