Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters fix blurfilter identifier, create a new color filter #101

Closed
wants to merge 3 commits into from
Closed

Filters fix blurfilter identifier, create a new color filter #101

wants to merge 3 commits into from

Conversation

arsonik
Copy link
Contributor

@arsonik arsonik commented Apr 18, 2016

No description provided.

arsonik added 3 commits April 18, 2016 16:23
@arsonik
fix BlurFilter unique identifier
52169a0
@arsonik
create a ColorControlsFilter
4f47e70 
Use saturation, contrast, brightness of CIColorControls
@arsonik
Propose a new CoreImageFilter protocol
825bbdc 
adopting the protocol makes it easier to create future coreimage filters
- auto create unique identifier with struct name and filterParams
- avoid redundant code "var filter: Image -> Image { get }"
@cnoon
Copy link
Member

cnoon commented Oct 2, 2016

Hi @arsonik,

Thanks for putting this together! I like the CoreImageFilter protocol. I pulled it into master in 805c7cb while keeping your attribution. I don't want to add the CoreControlsFilter though. The only direct CoreImage filter I think we should support in AFI is blur. All the others can easily be extended.

Thanks again! 🍻

@cnoon cnoon closed this Oct 2, 2016
@cnoon cnoon self-assigned this Oct 2, 2016
@cnoon cnoon modified the milestones: 3.1.0, 3.0.1 Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cnoon cnoon

Labels
image filter
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arsonik @cnoon