Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageCache always returns false when using removeImageWithIdentifier method. #152

Closed
asifbilal786 opened this issue Aug 17, 2016 · 3 comments
Assignees
Milestone

Comments

@asifbilal786
Copy link

I am trying to remove the image from image cache using removeImageForRequest method of ImageCache. Although it performs the necessary work and delete the image from cache but it always returns false.

I think the issue is with dispatch_async_barrier block. Because the piece of code in it runs asynchronously hence it always return false.

Please fix this issue as it doesn't return true value when it has removed the image.

@cnoon
Copy link
Member

cnoon commented Aug 22, 2016

Thanks for reporting @asifbilal786. It was definitely wrong. I've pushed a fix in 6be1da8 which is part of #154. I've also added tests to verify the return value now works as expected.

I'm going to close this issue out. Please redirect all further comments to #154.

@cnoon cnoon closed this as completed Aug 22, 2016
@cnoon cnoon self-assigned this Aug 22, 2016
@cnoon cnoon added this to the 3.0.0 milestone Aug 22, 2016
@asifbilal786
Copy link
Author

Thanks for quick fix. As i have implemented Pods, so did you also update the Cocoa Pods for this?

@cnoon
Copy link
Member

cnoon commented Aug 22, 2016

The changes are still in review. Once we get it merged, we're going to release AF 4.0.0-beta.1 and AFI 3.0.0-beta.1. If you need to pull the changes in before, you can always point directly to the beta6 branch in #154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants