Fix Session Manager Configuration's broken links in README #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishrutshah
changed the title
cnoon
requested changes
Sep 27, 2016
| @@ -360,7 +360,7 @@ Alamofire.request("https://httpbin.org/get").validate().responseJSON { response | |||
|
|
|||
| Response Caching is handled on the system framework level by [`URLCache`](https://developer.apple.com/reference/foundation/urlcache). It provides a composite in-memory and on-disk cache and lets you manipulate the sizes of both the in-memory and on-disk portions. | |||
|
|
|||
| > By default, Alamofire leverages the shared `URLCache`. In order to customize it, see the [Session Manager Configurations](#session-manager-configurations) section. | |||
| > By default, Alamofire leverages the shared `URLCache`. In order to customize it, see the [Session Manager Configurations](#advanced-usage) section. | |||
There was a problem hiding this comment.
These should be session-manager instead of advanced-usage throughout this PR.
There was a problem hiding this comment.
Sure. Thanks for the feedback. Updated PR 👍
|
Sweet! Thanks @vishrutshah! 🍻 |
bdonkey
added a commit
to bdonkey/Alamofire
that referenced
this pull request
Oct 23, 2016
* 'master' of github.com:Alamofire/Alamofire: (26 commits) [Issue Alamofire#1672] Added Request retryCount property to support RequestRetrier. Fixed test target compiler warning by not requiring app extension APIs only. [PR Alamofire#1670] Fixed compiler issue with DownloadRequest in AF4 migration guide. SPM package file now excludes tests since current configuration is not supported. Pulled in the release notes for the 3.5.1 release into the CHANGELOG. Added docstrings and note to README about resumeData and background sessions. Add 10.12 check for tests results, as macOS results are now correct. Added missing dashes in CHANGELOG…no functional changes. [PR Alamofire#1633] Fixed sample code in the README where error was used incorrectly. [PR Alamofire#1625] Fixed Session Manager internal links in the README. [PR Alamofire#1615] Fixed compiler error in response validation sample code in README. Added release notes to the CHANGELOG and bumped the version to 4.0.1. Removed excess whitespace from some of the docstrings…no functional changes. Removed framework and test target overrides that duplicated project settings. [PR Alamofire#1612] Fixed compilation issue in response handler section of the README. Fixed up if statement formatting…no functional changes. Added test verifying download request can be resumed with resume data. [Issue Alamofire#1551] Fixed retain cycle when using Validation clsoures. Fixed alignment in Travis yaml file…no functional changes. [PR Alamofire#1520] Renamed OSX to macOS throughout the project. ...
bdonkey
added a commit
to bdonkey/Alamofire
that referenced
this pull request
Nov 1, 2016
* 'master' of github.com:Alamofire/Alamofire: (27 commits) [PR Alamofire#1721] Improve embedded framework installation instructions. [PR Alamofire#1722] Update README for proper error checking in download. [Issue Alamofire#1672] Added Request retryCount property to support RequestRetrier. Fixed test target compiler warning by not requiring app extension APIs only. [PR Alamofire#1670] Fixed compiler issue with DownloadRequest in AF4 migration guide. SPM package file now excludes tests since current configuration is not supported. Pulled in the release notes for the 3.5.1 release into the CHANGELOG. Added docstrings and note to README about resumeData and background sessions. Add 10.12 check for tests results, as macOS results are now correct. Added missing dashes in CHANGELOG…no functional changes. [PR Alamofire#1633] Fixed sample code in the README where error was used incorrectly. [PR Alamofire#1625] Fixed Session Manager internal links in the README. [PR Alamofire#1615] Fixed compiler error in response validation sample code in README. Added release notes to the CHANGELOG and bumped the version to 4.0.1. Removed excess whitespace from some of the docstrings…no functional changes. Removed framework and test target overrides that duplicated project settings. [PR Alamofire#1612] Fixed compilation issue in response handler section of the README. Fixed up if statement formatting…no functional changes. Added test verifying download request can be resumed with resume data. [Issue Alamofire#1551] Fixed retain cycle when using Validation clsoures. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.