[1269] Update generation of the OS version part of the user agent to use non-localized sources.

[jshier]

Fixes #1269. Updates the user agent’s OS version to use non-localized sources. It also includes the actual OS name in the string.

[cnoon]

Okay so I've spent some time making sure that we get this exactly right. Here's a few examples of what we get if we don't change anything.

English

• Process Info: Version 9.3 (Build 13E230)
• User Agent: appname/bundle_id (1606122225; OS Version 9.3 (Build 13E230))

Japanese

• Process Info: バージョン 9.3（ビルド 13E230）
• User Agent: appname/bundle_id (1606122229; OS bajon 9.3(birudo 13E230))

Spanish

• Process Info: Versión 9.3 (Fase 13E230)
• User Agent: appname/bundle_id (1606122227; OS Version 9.3 (Fase 13E230))

Russian

• Process Info: Версия 9.3 (Выпуск 13E230)
• User Agent: appname/bundle_id (1606122226; OS Versia 9.3 (Vypusk 13E230))

Thai

• Process Info: เวอร์ชั่น 9.3 (บิลด์ 13E230)
• User Agent: appname/bundle_id (1606122228; OS wexrchan 9.3 (bi ld 13E230))

Therefore, we definitely need to make this change!

Now what's interesting is that we no longer need to run the CFStringTransform. It's not possible to have a non-latin character come through as the app name or the bundle id. I spent some time trying this out, and Apple replaces any non-latin characters in the app name or bundle id with nothing or a -. Therefore, we no longer need to run the CFStringTransform on this string to be safe. I'll update the PR based on this info.

[cnoon]

Removed the CFStringTransform logic in 3591bfa and then rebased.

[onmyway133]

@jshier thanks, but we miss the OS build version (like Build 13E230), right?

[cnoon]

Yes, the build number is no longer going to be present because we cannot extract it in a non-localized manner.

[bgerstle]

@cnoon I would love to know how you tested this. I mentioned that I tried a few things, but couldn't get the operatingSystemVersionString value to change. Thanks for providing a fix we can all benefit from!

[cnoon]

Hi @bgerstle,

One of the apps I work on is localized in 20 languages. All I did was drop some log messages into our AppDelegate printing out the operatingSystemVersionString values and ran it in the different languages posted above as an experiment.

You can easily add additional localizations to a sample project by adding a new localization in your project's Info settings. Here's a link to get you started if you haven't done this before. Then you can switch between locales when launching by switching Scheme's runtime language which can be done by Edit Scheme -> Run -> Options -> Application Language.

Cheers. 🍻

[bgerstle]

Thanks! But the strange thing is, we've had reports of this happening in
languages our app isn't localized in 😖. Anyway, thanks again for providing
more info!
On Fri, Jun 17, 2016 at 7:31 AM Christian Noon [email protected]
wrote:

Hi @bgerstle https://github.com/bgerstle,

One of the apps I work on is localized in 20 languages. All I did was drop
some log messages into our AppDelegate printing out the
operatingSystemVersionString values and ran it in the different languages
posted above as an experiment.

You can easily add additional localizations to a sample project by adding
a new localization in your project's Info settings. Here's a link
http://www.appcoda.com/localization-tutorial-ios8/ to get you started
if you haven't done this before. Then you can switch between locales when
launching by switching Scheme's runtime language which can be done by Edit
Scheme -> Run -> Options -> Application Language.

Cheers. 🍻

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1292 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAbHOTHWyBvox391AH3niBFc3B7zQjaeks5qMq-3gaJpZM4IuS5b
.