Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Output files configurable download location (e.g., to the local machine; to a bucket; etc.) #26

Open
arpita0911patel opened this issue Apr 7, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@arpita0911patel
Copy link
Contributor

arpita0911patel commented Apr 7, 2023

Is your feature request related to a problem? Please describe.
Need to enhance the HelloNGEN.sh script so that the location of the output files is configurable. They could get downloaded on the user's local machine if needed; or perhaps directed into a bucket, etc..

Describe the solution you'd like
Either in the realization file (requires upstream changes) or in some portion of the docker/wrapper script and wrapper configuration, include an option for the output location that is flexible and configurable. Optimally, the solution will have flexibility to be incorporated at a more upstream point when resources are available to make that change.

Describe alternatives you've considered
The alternative would be to go ahead and make the upstream change. We should touch base with the ngen team to see if this is underway.

Additional context
... coming soon...

@arpita0911patel
Copy link
Contributor Author

@benlee0423

@jameshalgren jameshalgren changed the title Output files download to the local machine Output files configurable download location (e.g., to the local machine; to a bucket; etc.) Apr 24, 2023
@benlee0423
Copy link
Collaborator

@ZacharyWills Are you currently working on it? If not, I will work on this. Let me know.

@benlee0423
Copy link
Collaborator

@ZacharyWills @arpita0911patel
Any copy command after ngen command in HelloNGEN.sh might not run.
I did very simple experiment how files are copied to host machine with entrypoint execution.
I created the following run.sh file,

#!/bin/bash
echo prehello > /ngen/data/prehello.txt
/echo-hello
echo hello > /ngen/data/hello.txt

And run this as entrypoint in Dockerfile

...
ENTRYPOINT [ "/run.sh"]

Run the image with the command

docker run --rm -it -v /Users/benjaminlee/data:/ngen/data <<IMAGE_ID>>

In my host machine, I am seeing prehello.txt file, but not hello.txt.

benjaminlee$ pwd
/Users/benjaminlee/data
benjaminlee$ ls
prehello.txt

So, in recent commit, putting copy command inside ngen command should work. I will run this locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants