Remove data from the stored sqlCache statement closure
#2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mory leak AlaSQL#2027 - Remove the `data` property from the sql cache after executing the query
…mory leak AlaSQL#2027 - Add assertions
paulrutter
changed the title
paulrutter
changed the title
data from the stored sqlCache statement closure
…mory leak AlaSQL#2027 - Add assertions
…mory leak AlaSQL#2027 - Add comment
paulrutter
commented
Jan 9, 2025
|
Fix released as part of v4.2.6 |
|
@mathiasrw thanks for merging! Btw, we just released a feature to our product using AlaSQL, see https://support.blueconic.com/en/articles/254081-q1-2025-blueconic-release-notes. A nice showcase of the power of AlaSQL. |
|
This is great. It makes me very happy to see things like this! And what a grat use case for AlaSQL: timeline rollup specified by the user. |
|
That's why i have been working on the parser, as we use it for several things in the product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
dataproperty from the sql cache after executing the query, as it's pointless for re-using from cache.It just retains table data which could otherwise be garbage collected sooner.
Fixes #2027.
Thank you for the time you are putting into AlaSQL!