Added fix for IndexDB version not incrementing due to parallal execution of sql statements #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is such a good point. Thank you! Any chance you can think about how we add a few tests for this? |
Julias0
commented
Jun 12, 2023
Have added a new test to check this scenario @mathiasrw Lemme know if it works. |
|
I really like how precise you nailed this problem. |
|
Released as part of v4.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1641
Inside 91indexeddb.js,
Since PromiseAll triggers all of the statements at the same time, it causes version to get incremented only once even if multiple DDL statements are present. Have modified the behaviour to execute the queries sequentially which will prevent race conditions such as these from coming up