-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Toolbar #1334
Open
benjamin-kirkbride
wants to merge
27
commits into
Akuli:main
Choose a base branch
from
benjamin-kirkbride:feat_control_tabs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: Toolbar #1334
benjamin-kirkbride
wants to merge
27
commits into
Akuli:main
from
benjamin-kirkbride:feat_control_tabs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
really not sure why this was broken, I'm 100% sure I had this working yesterday..........
Also, I rebased all my other branches onto this one, that will need worked through at some point but till then focus on 8775d89 - that is where the changes are. |
One thing in particular I would like feedback on is how to test this. The buttons are being generated dynamically, so I'm not sure how to "emulate" clicking them to verify their functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1332
This is a first pass, looking for feedback.
Please don't get caught up on the current buttons being for
black
andisort
, I am sure you feel that having a dedicated toolbar for these are not of much value, and I agree, but they were the easiest to start with as an example.I am seeking feedback on how I implemented the toolbar, and how it is interacted with from other plugins. Ideally we come up with a pattern for "registering" "commands" that can be selectively shared between the toolbar, Command Palette, right click menu, and probably the main menu as well?
Features I have thought of, and their status:
PS I may have gone a bit overboard with the custom classes 😅