-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git blame plugin #1302
base: main
Are you sure you want to change the base?
Add git blame plugin #1302
Conversation
Maybe the blame functionality should be behind a right-click, so that it doesn't consume CPU power and e.g. make your laptop battery run out quicker. |
Most other editors wait for a hover on a line to render or the first line selected/the insert location. |
Currently this doesn't do anything, simply prints the info, but yeah, I was wondering when it should actually show it, and where. |
I would use the selection/insert and hover (if hover is possible with tkinter Text (maybe a tag_add but that adds more processing time). |
Found this screenshot of vscode online, IMO it's a pretty good option: It assumes that the editor is wide enough to fit stuff to the side, but Maybe the best way to show the stuff would be to not actually insert something to the text widget, but add a label with the same font and background color as the text widget. |
Inserting it to the text widget screws up the highlighting, so then I'll go with the label. |
And what about putting it in the status bar, next to the line and column numbers? Line 12, column 34; changed by rdbende five months ago • this is a descriptive commit message Then we don't have to worry about scrolling, and more text would fit on the screen. Although this way it would be kinda weird to have a timeout before the label appears. |
In VS Code when you click on a git blame it will show the change on the line in a small popup, that would be cool to have. |
Resolves #1289