-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communicate between Porcupine instances #1215
Open
rdbende
wants to merge
17
commits into
main
Choose a base branch
from
one-instance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c9adb96
Communicate between porcu instances
rdbende 7bf3ce3
Merge branch 'main' of github.com:Akuli/porcupine into one-instance
rdbende af408c4
Revert "delete unused porcupine/_ipc.py (#786)"
rdbende c7eacc3
Switch to old _ipc.py based implementation
rdbende 1be3024
Run pycln, pyupgrade, black and isort
rdbende eb8fb86
remove print
rdbende 66de291
Merge branch 'one-instance' of github.com:Akuli/porcupine into one-in…
rdbende 570c26b
Merge branch 'main' into one-instance
rdbende 3d0cd91
huhh
rdbende e17866b
Run pycln, pyupgrade, black and isort
rdbende 11c9ee7
Remove unwanted new lines
rdbende b704ca9
Make mypy happy
rdbende 3ee8c37
Update docstring
rdbende 8daff30
I'm not sure what's the problem
rdbende 2b11465
Hmm... I don't get these exceptions locally
rdbende 282be23
Now what?
rdbende 6ad9c48
Ok then
rdbende File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably this doesn't work when opening from
tk send
. It would be nice if we could fix it (here or in a separate PR), so that you could doto show the output of the command in the currently running Porcupine instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it doesn't