Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Quit" is never clickable in file menu #1422

Closed
Akuli opened this issue Nov 6, 2023 · 3 comments
Closed

"Quit" is never clickable in file menu #1422

Akuli opened this issue Nov 6, 2023 · 3 comments
Labels
embarrassing

Comments

@Akuli
Copy link
Owner

Akuli commented Nov 6, 2023

Introduced in #1349
@taahol
Copy link
Contributor

taahol commented Dec 22, 2023

https://stackoverflow.com/q/11828270/17635987

@taahol
Copy link
Contributor

taahol commented Feb 7, 2024

porcupine/porcupine/menubar.py

Line 298 in d35e12e

if tab is not None and callback(tab):

Callback isn’t called when there is no tabs.

@Akuli
Copy link
Owner Author

Akuli commented Feb 7, 2024

IMO it should just pass a None to the callback when there are no tabs, so that the callback can decide what to do.

taahol added a commit to taahol/porcupine that referenced this issue Feb 8, 2024
@taahol
Tweak logic in enabling menu items
0f23a39 
fixes Akuli#1422
Akuli pushed a commit that referenced this issue Feb 9, 2024
@taahol @Akuli
Tweak logic in enabling menu items
78dc94b 
fixes #1422
@Akuli Akuli mentioned this issue Feb 9, 2024
Closed
@Akuli Akuli closed this as completed in 0b82c47 Feb 9, 2024
@Akuli Akuli mentioned this issue Apr 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
embarrassing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak logic in enabling menu items Akuli/porcupine
2 participants
@Akuli @taahol